Update CHANGES.md for 2.6 release #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For both GitHub Sponsors and PayPal Links only currently, no buttons yet See also: https://github.com/sponsors/richfromm/dashboard#next-steps https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/displaying-a-sponsor-button-in-your-repository
not sizing yet, which I suspect might be a problem I don't have a good way of truly testing this locally
and switch paypal to svg
but the list item itself is still markdown these are for the donation buttons
I'm doubtful this will make a difference
and use <li> for list item
instead of CSS which github md doesn't seem to actually support: https://github.com/orgs/community/discussions/22728
keep image link as HTML for now
with just HTML for the img tag
stick with the mostly markdown (plus HTML IMG) that works just experiment now with height 40 vs. 32
finalize (I hope) the markdown remove unused image files using svg now (not png) only paypal is local, github comes from elsewhere
richfromm
commented
Feb 14, 2023
README.md
Outdated
| contribution, you can make a donation via either: | ||
|
|
||
| * [GitHub Sponsors](https://github.com/sponsors/richfromm)[<img src="https://github.githubassets.com/pinned-octocat.svg" width="auto" height="32" valign="middle" hspace="10">](https://github.com/sponsors/richfromm) | ||
| * [PayPal](https://www.paypal.com/donate/?business=J46TL293CQ2M2&no_recurring=0¤cy_code=USD)[<img src="paypal.svg" width="auto" height="32" valign="middle" hspace="10">](https://www.paypal.com/donate/?business=J46TL293CQ2M2&no_recurring=0¤cy_code=USD) |
There was a problem hiding this comment.
This was shocklingly hard to get right. See all of the trial and error commits.
Typically I've been merging PR's, but I'm going to squash this one.
richfromm
commented
Feb 14, 2023
| @@ -2,6 +2,22 @@ | |||
|
|
|||
| ## Current releases, on [this fork](https://github.com/richfromm/slack2discord) | |||
|
|
|||
| ### 2.6 | |||
There was a problem hiding this comment.
I will tag 2.6 after this merges
This reverts commit 174eadf. It didn't empirically make any difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--ignore-file-not-foundoption to ignore any attached files that can'tbe found when downloading files
before running this script to perfom the Discord import
--downloads-dir, the file would always be freshly downloaded.a file exists with the same name, and the file size matches the
Content-LengthHTTP response header.Also:
(using either GitHub Sponsors, or PayPal)
.github/FUNDING.ymlto configure donations for githubSee https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/displaying-a-sponsor-button-in-your-repository